Add async throwing closure initializer for Result #2623
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Ryu0118 Thanks for exploring and taking the time to PR 😄 We actually snuck this initializer into our ConcurrencyExtras module here: pointfreeco/swift-concurrency-extras#15 This module should be exported by TCA, so long as you're on version 1.1+, so I think it should already be available. Is it not working for you? |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CasePathable macro eliminates the need to make the Action conform to Equatable, and the TaskResult is now deprecated.
However, the current TCA does not provide a complete replacement for TaskResult, and an extension to the Result must be created in each individual project.
I believe that this initializer should be added to TCA since it is most often used in an async effect being returned from a reducer.